Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect mention of 'Charge Subcategory' and correct with 'Charge Category' #527

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

cnharris10
Copy link
Contributor

Since 'Charge Subcategory' was rolled up into 'Charge Category', remove all references.

@cnharris10 cnharris10 requested a review from a team as a code owner August 20, 2024 14:18
@cnharris10 cnharris10 added this to the v1.1 milestone Aug 20, 2024
@cnharris10 cnharris10 added the bug in version A bug has been identified in one of the existing versions label Aug 20, 2024
@shawnalpay shawnalpay self-requested a review August 20, 2024 15:38
@cnharris10 cnharris10 requested review from ahullah and removed request for shawnalpay August 20, 2024 15:38
@ijurica
Copy link
Contributor

ijurica commented Aug 20, 2024

@cnharris10 there is also a typo. Could you please address that in this PR as well?

... discount purchases need the purchase amount the be amortized over the term the discount is applied ...

@jpradocueva jpradocueva added the P1 label Aug 20, 2024
@jpradocueva jpradocueva merged commit 5f86e45 into working_draft Aug 23, 2024
2 checks passed
@jpradocueva jpradocueva deleted the remove-reference-to-charge-subcategory branch August 23, 2024 07:43
@jpradocueva
Copy link
Contributor

The Members' group agreed on this PR on Aug 22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in version A bug has been identified in one of the existing versions
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

7 participants