Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capacityreservation*, sku* build issues #539

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix capacityreservation*, sku* build issues #539

merged 2 commits into from
Sep 12, 2024

Conversation

cnharris10
Copy link
Contributor

@cnharris10 cnharris10 commented Sep 10, 2024 •
edited
Loading

No change to content, just makes the working_draft branch pass builds

  1. Adds capacityreservation{id,status} columns to columns.mdpp file.
  2. Adds linter correction across all capacityreservation*, sku* columns:
  • - --> * bullets
  • spaces around lists

@cnharris10 cnharris10 requested a review from a team as a code owner September 10, 2024 12:58
@cnharris10 cnharris10 force-pushed the fix-capacity-reservation-columns branch from bb8efde to 9e21ab1 Compare September 10, 2024 12:59
@cnharris10 cnharris10 force-pushed the fix-capacity-reservation-columns branch from 9e21ab1 to 15b9820 Compare September 10, 2024 13:01
@cnharris10 cnharris10 force-pushed the fix-capacity-reservation-columns branch from 239c2e9 to c52f2d0 Compare September 10, 2024 13:10
@cnharris10 cnharris10 changed the title Fix capacity reservation columns Fix capacityreservation*, sku* build issues Sep 10, 2024
@cnharris10 cnharris10 merged commit d6dc4dc into working_draft Sep 12, 2024
2 checks passed
@cnharris10 cnharris10 deleted the fix-capacity-reservation-columns branch September 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udam-f2 udam-f2 udam-f2 approved these changes

@kk09v kk09v kk09v approved these changes

@gparker-at-sf gparker-at-sf gparker-at-sf approved these changes

@AWS-ZachErdman AWS-ZachErdman Awaiting requested review from AWS-ZachErdman

Assignees
No one assigned
Labels
None yet
Projects
FOCUS WG
Status: W.I.P
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnharris10 @udam-f2 @kk09v @gparker-at-sf