Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDITORIAL - Alternate version] Mark commitment discount purchase's pricing_category as "Standard" #579

Merged

Conversation

cnharris10
Copy link
Contributor

@cnharris10 cnharris10 commented Sep 30, 2024

No description provided.

@cnharris10 cnharris10 requested a review from a team as a code owner September 30, 2024 21:41
@cnharris10 cnharris10 changed the title [Alternate version] Mark commitment discount purchase's pricing_categ… [Alternate version] Mark commitment discount purchase's pricing_category as "Standard" Sep 30, 2024
@ijurica ijurica self-requested a review October 1, 2024 14:16
@ijurica
Copy link
Contributor

ijurica commented Oct 1, 2024

How should we categorize Unused Usage records—as Standard or Committed?
If purchases of commitment discounts are categorized as Standard, the unused portions of those purchases should also be categorized as Standard? It is covered by commitment discount purchase (i.e., BilledCost is 0), but is it Standard or Committed?

PricingCategory values (for reference)

  • Standard: Charges priced at the agreed upon rate for the billing account, including negotiated discounts. This includes any flat rate and volume/tiered pricing but does not include dynamic or commitment discount pricing.
  • Dynamic: ...
  • Committed: Charges with reduced prices due to a commitment discount specified by the Commitment Discount ID.
  • Other: ...

@jpradocueva jpradocueva added the consistency/review Consistency Review label Oct 1, 2024
@cnharris10
Copy link
Contributor Author

How should we categorize Unused Usage records—as Standard or Committed? If purchases of commitment discounts are categorized as Standard, the unused portions of those purchases should also be categorized as Standard? It is covered by commitment discount purchase (i.e., BilledCost is 0), but is it Standard or Committed?

PricingCategory values (for reference)

  • Standard: Charges priced at the agreed upon rate for the billing account, including negotiated discounts. This includes any flat rate and volume/tiered pricing but does not include dynamic or commitment discount pricing.
  • Dynamic: ...
  • Committed: Charges with reduced prices due to a commitment discount specified by the Commitment Discount ID.
  • Other: ...

Definitely Committed. You're just amortizing what was pre-purchased, non-refundable (after any initial return period), and thus is committed.

@jpradocueva jpradocueva added this to the v1.1 milestone Oct 2, 2024
@cnharris10 cnharris10 added the editorial Items that address editorial and minor changes label Oct 2, 2024
@cnharris10 cnharris10 changed the title [Alternate version] Mark commitment discount purchase's pricing_category as "Standard" [EDITORIAL - Alternate version] Mark commitment discount purchase's pricing_category as "Standard" Oct 2, 2024
@jpradocueva
Copy link
Contributor

Action Items from TF-2 call on October 2nd:

  • [TF2-#579 ] Chris, @cnharris10 : Create a separate PR to update relevant documentation and clarify definitions.

@jpradocueva
Copy link
Contributor

Approved during the Members' call on October 3.

@jpradocueva jpradocueva merged commit 7749677 into working_draft Oct 3, 2024
2 checks passed
@jpradocueva jpradocueva deleted the commitment-discount--pricing-category-purchases branch October 3, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency/review Consistency Review editorial Items that address editorial and minor changes
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

5 participants