Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes - links to FOCUS dataset glossary term #592

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

ijurica
Copy link
Contributor

@ijurica ijurica commented Oct 5, 2024

Editorial changes:

  • Replaced ...MUST be present in the billing data... with ...MUST be present in a FOCUS dataset... in the following columns:

    • CapacityReservation
    • ChargeClass
    • ConsumedUnit
    • SkuMeter
  • Added links to the FOCUS dataset glossary term for the remaining columns and other instances where the FOCUS dataset is mentioned.


Note: For three columns, there are concurrent editorial PRs addressing column ID formatting and making changes to the same code line. To simplify the merge process and avoid conflicts, links to the FOCUS dataset term are not included in this PR but have been added as suggestions in the respective PRs:

@ijurica ijurica requested a review from a team as a code owner October 5, 2024 21:59
@ijurica ijurica self-assigned this Oct 5, 2024
@ijurica ijurica added consistency/review Consistency Review editorial Items that address editorial and minor changes labels Oct 5, 2024
@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Oct 7:

  • [Maintainers-#592]: Check that every instance of the FOCUS dataset in the specification links to the glossary.

@jpradocueva jpradocueva added this to the v1.1 milestone Oct 8, 2024
@tobrien tobrien self-requested a review October 8, 2024 15:18
@jpradocueva
Copy link
Contributor

Approved during the Members' call on Oct 8.

@jpradocueva jpradocueva merged commit c6fb404 into working_draft Oct 8, 2024
2 checks passed
@jpradocueva jpradocueva deleted the editorial-link-to-focus-dataset branch October 8, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency/review Consistency Review editorial Items that address editorial and minor changes
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

6 participants