Skip to content

Commit

Permalink
fix: delete default options from plugins' .toolkitrc.yml files
Browse files Browse the repository at this point in the history
These options settings should probably have been removed when we added
the defaultOptions static field to the Task class, but they're out of
date at this point and causing validation issues when the types don't
match the current types. Their behaviour has been superseded by zod's
.default() method.
ivomurrell committed Mar 6, 2023
1 parent 2ea1998 commit 8a7d0ae
Showing 3 changed files with 0 additions and 16 deletions.
4 changes: 0 additions & 4 deletions plugins/eslint/.toolkitrc.yml
Original file line number Diff line number Diff line change
@@ -2,7 +2,3 @@ hooks:
'test:local': Eslint
'test:ci': Eslint
'test:staged': Eslint

options:
'@dotcom-tool-kit/eslint':
files: '**/*.js'
4 changes: 0 additions & 4 deletions plugins/mocha/.toolkitrc.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
hooks:
'test:local': Mocha
'test:ci': Mocha

options:
'@dotcom-tool-kit/mocha':
files: 'test/**/*.js'
8 changes: 0 additions & 8 deletions plugins/upload-assets-to-s3/.toolkitrc.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,2 @@
hooks:
'release:remote': UploadAssetsToS3

options:
'@dotcom-tool-kit/upload-static-assets':
directory: 'public'
bucket: 'ft-next-hashed-assets-prod'
destination: 'hashed-assets/uploaded'
extensions: 'js,css,map,gz,br,png,jpg,jpeg,gif,webp,svg,ico,json'
cacheControl: 'public, max-age=31536000, stale-while-revalidate=60, stale-if-error=3600'

0 comments on commit 8a7d0ae

Please sign in to comment.