Backwards compatible .toolkitrc options field #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
force-pushed
the
backwards-compatible-options
branch
from
4bc3228 to
e92f934
Compare
ivomurrell
reviewed
Apr 10, 2024
ivomurrell
reviewed
Apr 10, 2024
ivomurrell
approved these changes
Apr 10, 2024
Base automatically changed from
slightly-more-backwards-compatible
to
CPP-1852-task-vs-plugin-options
April 10, 2024 10:51
apaleslimghost
force-pushed
the
backwards-compatible-options
branch
from
b2f4c27 to
6015856
Compare
ivomurrell
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ions Backwards compatible .toolkitrc options field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old
.toolkitrcs containoptionswith just plugin options. these are now nested underoptions.plugins. if anoptionsis non-empty, but doesn't contain any of the new top-level fields, assume it's old-style, and nest it.nb this probably won't actually work in most cases, as the options are all moving around in #570. but we'll at least get semi-useful schema errors. maybe?