Fix lack of newlines in subprocess logging #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts d1374d1, which I think was a mistake as we already remove the EOL character normally added by winston, and we skip appending a newline character to messages if it has a `process` attribute. So it meant that the only newlines that would be preserved were ones that happened to not be at the end (or start) of a stream flush.
joelcarr
approved these changes
May 21, 2024
Because we were declaring a regex within a template literal we needed to escape the backslash in the `\s` whitespace meta group. I we don't, the backslash is parsed as an escape character for the template literal, not the regex, and is replaced with a literal `s` as `\s` is not a valid escape sequence. This means the regex would search for an `s` instead of whitespace. This doesn't affect the unescaped `\n` as the escaped `\n` and the literal `0x0A` ASCII character are (roughly) equivalent in a regex. Instead of fixing the incorrect `\s`, let's remove it entirely and not trim whitespace characters, just newlines, as I'm not sure we actually want to strip indentation from hooked console logging.
joelcarr
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This partially reverts d1374d1, which I think was a mistake as we already remove the EOL character normally added by
winston, and we skip appending a newline character to messages if it has aprocessattribute. So it meant that the only newlines that would be preserved were ones that happened to not be at the end (or start) of a stream flush.Running the
Mochatask in next-static before this change:Running the
Mochatask in next-static after this change:And here is what the output looks like when
mochais run directly instead. Note the matching amount of whitespace.Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too