fix: allow multiple instances of task with different options #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
force-pushed
the
multiple-task-instances
branch
from
b4f7dab to
22c8855
Compare
ivomurrell
approved these changes
Jul 29, 2024
ivomurrell
pushed a commit
that referenced
this pull request
Sep 5, 2024
fix: allow multiple instances of task with different options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadTasksreturned aRecord<string, Task>, meaning that a command with multiple instances of the same task would just load the last created instance (with the last specified options), meaning tasks couldn't be called multiple times with different options.