Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise calls between PAC and Publishing #83

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

angelraynovft
Copy link
Contributor

Description

This PR intends to sync the draft annotations with the Publishing cluster regarding write operations. This solution is temporary until we decommission the PAC cluster.

What

For this goal, I created a small API with a function that gets the incoming write requests and before processing it we are duplicating it and sending it to the publishing cluster. Currently, we are redirecting the calls to publishing-dev-eu.

Why

https://financialtimes.atlassian.net/browse/UPPSF-5389

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"

  • Test coverage is not significantly decreased
  • All PR checks have passed
  • Changes are deployed on dev before asking for review
  • Documentations remains up-to-date
    • OpenAPI definition file is updated
    • README file is updated
    • Documentation is updated in upp-docs and upp-public-docs
    • Architecture diagrams are updated

This Pull Request follows the rules described in our Pull Requests Guide

@angelraynovft angelraynovft requested a review from a team as a code owner September 16, 2024 13:36
antoanFT
antoanFT previously approved these changes Sep 17, 2024
@antoanFT antoanFT requested a review from a team September 17, 2024 07:23
tsvetko24
tsvetko24 previously approved these changes Sep 17, 2024
@angelraynovft angelraynovft dismissed stale reviews from tsvetko24 and antoanFT via 9d45d5f September 24, 2024 13:52
@angelraynovft angelraynovft force-pushed the UPPSF-5389-sync-annotations-pac-and-publish branch from a11d967 to 9d45d5f Compare September 24, 2024 13:52
@coveralls
Copy link

coveralls commented Sep 24, 2024

Coverage Status

coverage: 72.844% (-18.6%) from 91.426%
when pulling b24e767 on UPPSF-5389-sync-annotations-pac-and-publish
into 7eefaf3 on master.

@angelraynovft angelraynovft changed the title tech clean up Synchronise calls between PAC and Publishing Sep 24, 2024
@angelraynovft angelraynovft force-pushed the UPPSF-5389-sync-annotations-pac-and-publish branch from 9d45d5f to b191115 Compare September 24, 2024 13:57
Create a synchronizer api that copy the incoming write requests and sends them to the
Publishing cluster.
@angelraynovft angelraynovft force-pushed the UPPSF-5389-sync-annotations-pac-and-publish branch from b191115 to b24e767 Compare September 24, 2024 14:19
@antoanFT antoanFT requested a review from a team September 30, 2024 06:49
@angelraynovft angelraynovft merged commit 2126d4d into master Oct 3, 2024
2 checks passed
@angelraynovft angelraynovft deleted the UPPSF-5389-sync-annotations-pac-and-publish branch October 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants