Match the schema in the publishing cluster #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are introducing an annotations body struct which helps us match the schema in the publishing cluster. This way we can filter the required fields and avoid validation errors.
asparuhft
approved these changes
Oct 7, 2024
angelraynovft
deleted the
fix/UPPSF-5624-validate-annotations-schema-in-pac-before-sending-to-publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the deployment of the annotations synchronization between PAC and Publishing cluster. We were sending PAC requests that does not validate with the annotation schemas in the publishing cluster causing errors.
What
We are introducing an annotations body struct which helps us match the schema in the publishing cluster. This way we can filter the required fields and avoid validation errors.
Why
https://financialtimes.atlassian.net/browse/UPPSF-5624
Anything, in particular, you'd like to highlight to reviewers
Changes can be tested on Staging
Scope and particulars of this PR (Please tick all that apply)
DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"
This Pull Request follows the rules described in our Pull Requests Guide