Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only link to Panic Guide when a URL is given #10

Merged
merged 1 commit into from
May 25, 2017
Merged

Conversation

lucas42
Copy link
Member

@lucas42 lucas42 commented May 22, 2017

The healthcheck standard allows for panic guides to provided inline, rather than a link to a doc. At the moment when we do this, they look a bit silly because our html representation attempts to create a link anyway.

@lucas42 lucas42 requested a review from bogdanguranda May 22, 2017 14:49
Copy link
Contributor

@bogdanguranda bogdanguranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lucas42 lucas42 merged commit e7ccca0 into master May 25, 2017
@lucas42 lucas42 deleted the panicguidelinks branch May 25, 2017 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants