Skip to content

Commit

Permalink
Remove denodeify
Browse files Browse the repository at this point in the history
We've had promise-based file system functions for an age.
  • Loading branch information
rowanmanning committed Oct 14, 2024
1 parent 22b17d3 commit b00ed80
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
5 changes: 3 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"@dotcom-reliability-kit/logger": "^3.0.3",
"@dotcom-reliability-kit/serialize-request": "^3.0.1",
"@financial-times/n-flags-client": "^15.0.0",
"denodeify": "^1.2.1",
"express": "^4.17.3",
"isomorphic-fetch": "^3.0.0",
"n-health": "^13.0.0",
Expand Down
5 changes: 1 addition & 4 deletions src/lib/instrument-listen.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@ const metrics = require('next-metrics');
const logger = require('@dotcom-reliability-kit/logger');
const http = require('http');
const https = require('https');
const denodeify = require('denodeify');
const path = require('path');
const {readFile} = require('fs/promises');
const {STATUS_CODES} = http;
const serializeRequest = require('@dotcom-reliability-kit/serialize-request');

const fs = require('fs');
const readFile = denodeify(fs.readFile);

module.exports = class InstrumentListen {
constructor (app, meta, initPromises) {
this.app = app;
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node12/tsconfig.json",
"extends": "@tsconfig/node18/tsconfig.json",
"compilerOptions": {
"allowJs": true,
"checkJs": true,
Expand Down

0 comments on commit b00ed80

Please sign in to comment.