Remove non-existent services #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
approved these changes
Jul 21, 2022
|
This has conflicts now but @alexmuller we should merge in Jan |
alexmuller
force-pushed
the
remove-non-existent-service
branch
from
7459cdf to
e73fc81
Compare
|
@rowanmanning Sorry I left this a long time but are you still happy for it to go in as a major version? Along with #501 and #550. |
joelcarr
approved these changes
Mar 22, 2024
While reviewing a PR I noticed that we have a lot of services listed here which either don't have DNS or are Heroku apps that no longer exists. We should remove these from this file because we actually want alerts to go off if we're connecting to these services - it would indicate a problem. This is probably a breaking change.
alexmuller
force-pushed
the
remove-non-existent-service
branch
from
e73fc81 to
3cbc1ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing a PR I noticed that we have a lot of services listed here which either don't have DNS or are Heroku apps that no longer exists.
We should remove these from this file because we actually want alerts to go off if we're connecting to these services - it would indicate a problem.
This is probably a breaking change so we don't need to merge immediately, we can include it with the next major version.