chore: Add unmonitored urls for next-retention to metrics #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nazehs
force-pushed
the
update-next-retention-metrics
branch
from
75e8f17 to
8a95452
Compare
cerdfied
approved these changes
Sep 25, 2023
alexmuller
reviewed
Sep 26, 2023
lib/metrics/services.js
Outdated
| @@ -338,6 +338,8 @@ module.exports = { | |||
| 'user-subs-status-svc': /^https:\/\/(?:beta-)?api\.ft\.com\/users\/[0-9a-f]{8}-(?:[0-9a-f]{4}-){3}[0-9a-f]{12}\/subs-status/, | |||
| 'user-svc': /^https:\/\/(beta-)?api\.ft\.com\/users/, | |||
| 'user-svc-test': /^https:\/\/(beta-)?api-t\.ft\.com\/users/, | |||
| 'introductory-offers-for-apple': /^https:\/\/api.appstoreconnect\.apple\.com\/v1\/subscriptions\/[0-9]+\/introductoryOffers/, | |||
| 'volt-db-api': /^https:\/\/voltdb-api-global\.in\.ft\.com/, | |||
There was a problem hiding this comment.
voltdb-api-global.in.ft.com should be covered by ip-voltdb-api a bit further up the file! If that's not working for some reason let's amend that one instead.
There was a problem hiding this comment.
@alexmuller apparently it's throwing an alert for that endpoint too. However, i will remove it now and see the behaviour .
danieleruiz
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently next-retention is throwing an alert for ops team because of unmonitored metrics that we have not added.
This PR adds the metrics that are missing for use to properly monitor all the end points that we are calling in next-retention.
heimdall
Jjira ticket