Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from ip-voltdb-api #528

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

alexmuller
Copy link
Member

This isn't really needed and some services are calling it without the slash.

@alexmuller alexmuller requested review from a team as code owners September 29, 2023 13:03
@alexmuller alexmuller requested a review from a team October 3, 2023 08:49
@rowanmanning rowanmanning enabled auto-merge (rebase) July 26, 2024 14:58
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.5.2 to 1.13.7.
- [Commits](jashkenas/underscore@1.5.2...1.13.7)

---
updated-dependencies:
- dependency-name: underscore
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@rowanmanning rowanmanning force-pushed the remove-trailing-slash-voltdb branch from d31610e to e418c87 Compare July 26, 2024 15:02
@rowanmanning rowanmanning requested a review from next-team as a code owner July 26, 2024 15:02
lib/metrics/services.js Dismissed Show dismissed Hide dismissed
@rowanmanning rowanmanning merged commit f1945d9 into main Jul 26, 2024
16 of 17 checks passed
@rowanmanning rowanmanning deleted the remove-trailing-slash-voltdb branch July 26, 2024 15:03
@rowanmanning
Copy link
Member

Oops I ruined this PR 🤦 just gonna close it because we'll probably remove service thingies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants