Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub(x) AWS domain #551

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add sub(x) AWS domain #551

merged 1 commit into from
Mar 22, 2024

Conversation

alexmuller
Copy link
Member

We're connecting to this domain from next-subscribe and next-barrier-page which is causing alerts.

@alexmuller
Add sub(x) AWS domain
50e47c3 
We're connecting to this domain from next-subscribe and
next-barrier-page which is causing alerts.
@alexmuller alexmuller requested a review from a team March 22, 2024 17:15
@alexmuller alexmuller requested review from a team as code owners March 22, 2024 17:15
ludrob
ludrob approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ludrob ludrob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but just a note that this is not final and the url will change in the coming days.
We don't know yet what it will be, subx have been quite frustrating to deal with :(

@alexmuller
Copy link
Member Author

Cool, thank you! It'll be good to have a real domain for this in any case.

@alexmuller alexmuller merged commit 89a4e59 into main Mar 22, 2024
11 checks passed
@alexmuller alexmuller deleted the add-subx-sendconversiondata branch March 22, 2024 17:18
@JuanTincho JuanTincho mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludrob ludrob ludrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmuller @ludrob