Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register insights endpoint for topic recommendation #561

Merged
merged 2 commits into from
May 30, 2024

Conversation

camillecroci
Copy link
Contributor

@camillecroci camillecroci commented May 30, 2024

Adding metrics services for topic recommendation endpoint:
https://api.ft.com/snr/v1/insights/recommended-articles/{{USER_ID}}

Got a code scanning failure from CodeQL about escaping the . in api.ft.com:

Incomplete regular expression for hostnames
This regular expression has an unescaped '.' before 'ft.com', so it might match more hosts than expected.

so I added that to all the insights endpoints. Hopefully it should not cause any issue, or if it does, it means one of our services was not correctly registered and we can add it.

@camillecroci camillecroci requested review from a team as code owners May 30, 2024 10:15
lib/metrics/services.js Fixed Show fixed Hide fixed
@camillecroci camillecroci merged commit e422d79 into main May 30, 2024
13 checks passed
@camillecroci camillecroci deleted the cc/register-insight-topic-reco-endpoint branch May 30, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants