Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offer-api #563

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Update offer-api #563

merged 1 commit into from
Jun 7, 2024

Conversation

andygout
Copy link
Contributor

@andygout andygout commented Jun 7, 2024

next-newsletter-signup's healthchecks are currently failing with:

{
	"id": "all-services-registered-us",
	"name": "Metrics: All services for newsletter-signup registered in next-metrics in us",
	"ok": false,
	"checkOutput": "https://api.ft.com/membership/offers/v2/ce949b25-9ff1-3e92-e136-b7858bb55214, https://api.ft.com/membership/offers/v2/a8854b82-d47f-e1f1-83f2-e236b6339eaa services called but no metrics set up.",
	"lastUpdated": "2024-06-07T13:37:57.516Z",
	"panicGuide": "See next-metrics/lib/metrics/services.js and set metrics for the service, then release next-metrics and rebuild this app.",
	"severity": 3,
	"businessImpact": "We don't have any visibility with unregistered services.",
	"technicalSummary": "Set up services' metrics in next-metrics/lib/metrics/services.js to send to Graphite."
},

This is as a result of these recent changes to that app (https://github.com/Financial-Times/next-newsletter-signup/pull/813), which fetches offer data from the Offer API with which to populate the prices for the niche newsletter paid subscriptions.

Inside Politics production environment offer ID

https://api.ft.com/membership/offers/v2/ce949b25-9ff1-3e92-e136-b7858bb55214

Screenshot 2024-06-07 at 15 17 44


Unhedged production environment offer ID

https://api.ft.com/membership/offers/v2/a8854b82-d47f-e1f1-83f2-e236b6339eaa

Screenshot 2024-06-07 at 15 19 44


N.B.

I have confirmed that the existing values that this PR removes are deprecated — see this Slack thread.


Ticket

@andygout andygout requested a review from a team June 7, 2024 14:25
@andygout andygout requested review from a team as code owners June 7, 2024 14:25
@andygout andygout merged commit a87d0a0 into main Jun 7, 2024
13 checks passed
@andygout andygout deleted the update-offer-api branch June 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants