Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the latest Tool Kit major versions #604

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

rowanmanning
Copy link
Member

No description provided.

@rowanmanning rowanmanning requested review from next-team and a team as code owners October 2, 2024 09:15
@rowanmanning rowanmanning enabled auto-merge (rebase) October 2, 2024 10:49
Copy link
Member

@alexmuller alexmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only thing I'm confused by is in the CircleCI config, are we running the publish tag job on all 3 executors now?

.circleci/config.yml Outdated Show resolved Hide resolved
@rowanmanning rowanmanning marked this pull request as draft October 2, 2024 13:21
auto-merge was automatically disabled October 2, 2024 13:21

Pull request was converted to draft

@rowanmanning rowanmanning marked this pull request as ready for review October 3, 2024 10:17
@rowanmanning rowanmanning enabled auto-merge (rebase) October 3, 2024 10:50
@rowanmanning rowanmanning merged commit df5c23b into main Oct 4, 2024
16 checks passed
@rowanmanning rowanmanning deleted the toolkit-4 branch October 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants