Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit PR creation #149

Closed
ivomurrell opened this issue Aug 2, 2021 · 1 comment · Fixed by #164
Closed

Rate limit PR creation #149

ivomurrell opened this issue Aug 2, 2021 · 1 comment · Fixed by #164

Comments

@ivomurrell
Copy link
Contributor

After creating 21 PRs in a row the 22nd PR returned an HTTP error for me:

You have triggered an abuse detection mechanism and have been temporarily blocked from content creation. Please retry your request again later.

(The rest of the PRs were created without issue.)

We should add some rate limiting to calls to the GitHub API so we avoid sporadically getting this error.
ivomurrell added a commit that referenced this issue Aug 20, 2021
@ivomurrell
Retry requests on abuse limits as well
a435bf0 
We've been running into abuse limiting when creating many PRs for a
workspace, presumably as a result of secondary rate limiting. From
GitHub's best practises documentation:

> Requests that create content which triggers notifications, such as
issues, comments and pull requests, may be further limited and will not
include a Retry-After header in the response. Please create this content
at a reasonable pace to avoid further limiting.

Requests are retried at a minimum of 5 seconds after the original, which
is probably what we want even if the documentation is (intentionally)
vague.

Closes #149
@ivomurrell ivomurrell mentioned this issue Aug 20, 2021
Closed
ivomurrell added a commit that referenced this issue Aug 20, 2021
@ivomurrell
Retry requests on abuse limits as well
819922a 
We've been running into abuse limiting when creating many PRs for a
workspace, presumably as a result of secondary rate limiting. From
GitHub's best practises documentation:

> Requests that create content which triggers notifications, such as
issues, comments and pull requests, may be further limited and will not
include a Retry-After header in the response. Please create this content
at a reasonable pace to avoid further limiting.

Requests are retried at a minimum of 5 seconds after the original, which
is probably what we want even if the documentation is (intentionally)
vague.

Closes #149
@serena97
Copy link
Contributor

serena97 commented Nov 23, 2021 •
edited
Loading

Have opened #164 for this - it differs to 819922a as the PR's change will allow for retries to handle the creation of the subsequent PRs

@ivomurrell ivomurrell linked a pull request Nov 23, 2021 that will close this issue
Implement mechanism to avoid secondary rate limit on PR creation #164
Merged
ivomurrell added a commit that referenced this issue Nov 26, 2021
@ivomurrell
Retry requests on abuse limits as well
7588c93 
We've been running into abuse limiting when creating many PRs for a
workspace, presumably as a result of secondary rate limiting. From
GitHub's best practises documentation:

> Requests that create content which triggers notifications, such as
issues, comments and pull requests, may be further limited and will not
include a Retry-After header in the response. Please create this content
at a reasonable pace to avoid further limiting.

Requests are retried at a minimum of 5 seconds after the original, which
is probably what we want even if the documentation is (intentionally)
vague.

Closes #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ivomurrell @serena97