Fix add_input bug in add_fee of transaction builder #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findora-sun
approved these changes
Mar 14, 2022
akhilpeddireddy
approved these changes
Mar 14, 2022
harshadptl
added a commit
that referenced
this pull request
Apr 1, 2022
* CHANGELOG update * dding triple masking code to ledger and query server package * integrating finutils and all non-src * additions and fixes in wasm, query server and ledger (#173) also dependencies and misc changes * Added functionality to return list of randomizer strings through wasm * Adding WASM wrappers to triple masking key serialization/deserialization functions * anon pub key randomizer wasm * Returning Randomized AXfr pub key as string * ruc fixes and integration test scripts improvements * adding wasmcat into this branch * remove auto wasm build from pull request to main branch * Integrate zei arkworks backend (#192) switched to zei develop, added ark patch and fixes for BLSScalar bytes, changed anon keys * Nullifier hash, wasm oabar and integrate new setup params (#210) * added a function in wasm for nullifier hash generation * added to query server a way to check if a nullifier hash exists or not * added a wasm function to get oabar * made some changes to support new zei setup parameters * update positive unit test on txn_builder with anon fees (#208) * modified axfr_create_verify_unit_positive_tests() by adding fee input Author: hridambasu Co-authored-by: Serge-Juarez Co-authored-by: akhilpeddireddy Co-authored-by: Harshad Patil * wasm randomize AXfrKeyPair fn and fix lint lint errors due to rustwasm/wasm-bindgen#2774 * sync with zei updates * Fix node reset and start in devnet * fix compile error caused by yanked anomaly * Wasm function to deserialize ABAR * Fix nullifier hash serialization * Adding serialization, deserialization for AnonKeys object * Removing fee for non-Fra assets in bar2abar for testing * Fix AnonKeys serialization * Fix FeeInputs Vector capacity limit * Fix added capacity for FeeInputs * Integrating anon transfer fee and remainder with txn builder and CLI (#231) Co-authored-by: akhilpeddireddy <akhilpeddireddy@gmail.com> * cli abar spent status, handle randomizer for axfr remainder * fix build after zei merkle tree optimization * Abar to bar integration (#213) * Added abar_to_bar integration to the platform 1. made changes to ledger to handle the conv ops 2. added script to test abar_to_bar conversion on fresh local net * Wasm bindingg for abar_to_bar conversion operation * FeeOp for Abar - Bar conversions * change axfr public key in integration/demo script new keys are used after the arkworks switch in zei * fix compile error caused by yanked anomaly * Removing Rocksdb patch as the bug in librocksdb is fixed * Removed invalid short flags for fn commands * Fix public key and address CLI flags Co-authored-by: akhilpeddireddy <akhilpeddireddy@gmail.com> Co-authored-by: charlie <charlie@findora.org> * Fix FeeInputs multiple insert call * Fix build error * Fix new merkle tree depth and abar to bar demo script * adding wasm support for anon fee and remainder * fix storage version, lint and wasm build * fix clippy errors in smt * add back wasm_bindgen were removed in v3 when develop got merged in * Change names of wasm functions * Apply precompute verifier parameters (#246) * Apply precompute verifier parameters * hotfix verifier test code * Fix add_input bug in add_fee of transaction builder (#245) * Fix add_input bug in add_fee of transaction builder * fix fmt * Anon assets mixing (#244) * check abar unspent before transfer * update anon-transfer CLI to support assets * update anon-transfer-batch CLI to support assets * add test shell for anon assets mixing * fix multi_axfr_test shell * cleanup test tmp_file * cut down test shell sleep time * This includes the function descibed in FO-887 (#251) * This includes the function descibed in FO-887 * dding wasm interface to fee estimation Co-authored-by: Harshad Patil <harshad0402@gmail.com> * Anon Fee for ABAR to BAR (#249) * Updating zei library version * Regression tests for triple masking (#254) * Regression tests for - bar to abar - abar transfer - abar to bar * fix binary path * Anon fee for abar to bar conversion * Updating the zei library version * Upgrade zei version & hotfix unwrap * randomizer map and remove amount.rs (#256) * Update zei version for anon_fee * Triple masking docs (#258) * Adding docs for Abar conversions * fix SID pick in bar to abar conversion * Fix: user param generation after fee calculation in anon transfer * Fix algo for FRA fee estimation for some corner cases (#262) * Fix algo for FRA fee estimation for some corner cases * Fix fmt * Fix anon transfer transaction build * Fix build failure & txn serialization * Fix handle AXfrKeypair pointer in abar_to_bar conversion * Fix wasm Key null pointer issue Clonig all the signing and encryption keys to avoid moving of pointer in rust-wasm code. Co-authored-by: charlie <charlie@findora.org> Co-authored-by: Harshad Patil <harshad0402@gmail.com> Co-authored-by: tommady <tommady@users.noreply.github.com> Co-authored-by: Hridam Basu <hridam.basu@gmail.com> Co-authored-by: findora-crypto <weikeng@findora.org> Co-authored-by: Serge-Juarez <86990655+Serge-Juarez@users.noreply.github.com> Co-authored-by: Findora-Sun <94740291+findora-sun@users.noreply.github.com> Co-authored-by: Sun <sun@findora.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that you have executed all the following process and no errors occur
The major changes of this PR
Fixes an issue with add_fee in transaction builder
Extra documentations
For balance method to work, we have to send proper amount to be collected from each fee input. This change does that with logic borrowed from add_fee_relative_auto