This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
fix(image): Fixed a problem where image previews weren't being loaded #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly if there was a query string in the URL
|
👏 Thanks for catching and fixing this one! |
|
I might just end up releasing 5.10.1 with your two fixes next week, just so other have access to these in published releases. |
|
No problem. Awesome! That would be great! |
|
5.10.1 just released. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes [REQUIRED]
I fixed a problem where the if the thumbnail url returned from the server contained a query string, the image type defaults to jpeg, thus breaking any other file type previews
What browsers and operating systems have you tested these changes on? [REQUIRED]
Chrome on OS X
Are all automated tests passing? [REQUIRED]
Yes
Is this pull request against develop or some other non-master branch? [REQUIRED]
Yes