This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
test(package): lock pica to v2.0.8 #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pica recently released v3.0.0, with a breaking change which our tests rely on. This commit locks pica to the last stable version in order to make the test suite pass again.
Novex
changed the title
|
Good deal, thanks! |
rnicholus
approved these changes
Apr 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Pica very recently released v3.0.0, and appear to have renamed
pica.resizeCanvasto something else. This breaks the test suite, but not the build.This commit locks pica to the last working version, 2.0.8 in order to make the test suite pass again.
What browsers and operating systems have you tested these changes on?
Verified that the test suite now passes on Windows 8.1
Have you written unit tests? If not, explain why.
No, this is to make existing tests work again.