This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Use native Promise #1986
Open
Use native Promise #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: An error is thrown on load if a native promise implementation is not available.
BREAKING CHANGE: Drop support for non-native Promise implementations
|
Wow. I haven’t reviewed any of this yet, but it looks like you put a LOT of work into these changes... If you’re willing, I’d like to chat more at your convenience. |
|
Sure sounds good, what’s the best way to contact you? |
|
let's connect on twitter |
|
There are, arguably, too many changes to really review here. But tests are passing, and skimming though I didn't see anything that looked obviously wrong. So, maybe the best course if just to do some more manual testing, and if all looks good after a bit, merge it into the 6.0 branch. I'll probably pull this down myself and test it out when i get a chance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Convert all uses of
qq.Promiseor other promises to require nativePromiseinstead.What browsers and operating systems have you tested these changes on?
Firefox 59
Have you written unit tests? If not, explain why.
I've migrated existing tests to be async friendly.
I'm going to build off this branch for my product https://dovetailapp.com and give it some production testing. I'll be using the S3 chunked uploader.
Remaining issues
PromiseOptionswithPromise. Check implications of no longer allowing the promise to be resolved by callers (no more.successand.failure).