Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Transfer event #13

Open
naumenkogs opened this issue Feb 6, 2018 · 3 comments
Open

Transfer event #13

naumenkogs opened this issue Feb 6, 2018 · 3 comments
Assignees

Comments

@naumenkogs
Copy link
Contributor

If a contract contains payable fallback function, there could be events — for example, "token minted".
However, the current implementation of the transfer does not allow to handle events.

@naumenkogs
Copy link
Contributor Author

web3/web3.js#1377

naumenkogs added a commit that referenced this issue Feb 20, 2018
@carchrae
Copy link
Contributor

it isn't really clear what the issue is and what work has been done here. by clicking around and reading, i see you made a request to web3 to return transfer events for the fallback case.

my open question to you is how does this impact us. eg, here #11 (comment)

just a short comment explaining may be enough.

@naumenkogs
Copy link
Contributor Author

naumenkogs commented Feb 28, 2018

@carchrae I think this issue should be opened and wait until somebody respond on web3.js or implement stuff in web3.js.

The problem is: we can execute mint in 2 ways: explicit (tokenContract.methods.mint.send()) and implicit (send plain transfer to the tokenContract and call mint by falling into fallback function).

From what I see, there is no way we can handle raised events if we use the second way.

It basically means that: if we want to handle events raised by minting tokens, we should use explicit approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants