Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic versioning rule #310

Open
loloicci opened this issue Jun 26, 2023 · 3 comments
Open

semantic versioning rule #310

loloicci opened this issue Jun 26, 2023 · 3 comments

Comments

@loloicci
Copy link
Contributor

loloicci commented Jun 26, 2023

This repository now uses versions formatted x.x.x-y.y.y-zzz where x.x.x is the original CosmWasm's release version, y.y.y is our release version and zzz is the additional info (e.g. dynamiclink1). This does not observe the semantic versioning 2.0.0 (https://semver.org/spec/v2.0.0.html).

Problems:
Observing semantic versioning, -y.y.y-zzz means this is the prerelease version of x.x.x, so this means the version before the original's x.x.x has lower priority than it.

Solution:
Using "build metadata" and use versions formatted "x.x.x+y.y.y-zzz" or "x.x.x+finschia-y.y.y-zzz". This has the same priority as "x.x.x".

@loloicci
Copy link
Contributor Author

if we use our original version "x.x.x" and publish the compatibility table with the original CosmWasm, our "x.x.x" should be newer than the original. This is because rust/cargo cannot patch newer version with older version.

@zemyblue
Copy link
Member

zemyblue commented Jun 26, 2023

How about replacing the current v1.1.1-0.7.0 with v1.0.0?
And how about setting the version with the dynamic link function to v1.0.0+dynamiclink1?

@loloicci
Copy link
Contributor Author

How about replacing the current v1.1.1-0.7.0 with v1.0.0?

as I said in #310 (comment), we should use a newer version than the compatible original for using [patch] feature of cargo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants