Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade wasmer version 2.0.0 #166

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Mar 3, 2022

Description

Closes: #160 #161 #174

The wasmer version in the cargo.lock was changed to 2.1.1 by cargo update in previous PRs.
This causes the dependent library hashbrown to not build on rust 1.54.0.

In the process below, wasmer pointed to 2.0.0 in the cargo.toml, but the version was probably changed in the cargo.lock by cargo update.(change up twice, 2.1.0, 2.1.1)
https://github.com/line/cosmwasm/pull/160/files#r818241050
646b24e#r67844444

Upstream cosmwasm 0.16.3 normally points to wasmer 2.0.0.
https://github.com/CosmWasm/cosmwasm/blob/22cfefab6217664e1e1d4baea2d1b6a48e6a4d62/Cargo.lock#L1706

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

The wasmer version was changed to 2.1.1 by cargo update in previous PRs.
This causes the dependent library hashbrown to not build on rust 1.54.0.
@brew0722 brew0722 added the VM label Mar 3, 2022
@brew0722 brew0722 self-assigned this Mar 3, 2022
@@ -777,15 +745,6 @@ version = "0.11.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ab5ef0d4909ef3724cc8cce6ccc8572c5c817592e9285f5464f8e86f8bd3726e"

[[package]]
name = "hashbrown"
version = "0.12.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashbrown 0.12.0 is removed normally.

@brew0722 brew0722 merged commit 67b9f3b into Finschia:main Mar 3, 2022
@brew0722 brew0722 deleted the fix-downgrade-wasmer-version-2.0.0 branch March 3, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants