Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dynamic callee returns tuple typed value #195

Merged
merged 11 commits into from
Jun 8, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented May 20, 2022

Description

closes #156

  • fix macros
  • fix documents
  • integration test

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this May 23, 2022
@loloicci
Copy link
Contributor Author

loloicci commented Jun 1, 2022

Integration Test Result

"logs":[{"msg_index":0,"log":"","events":[{"type":"execute_contract","attributes":[{"key":"contract_address","value":"link10pyejy66429refv3g35g2t7am0was7yaducgya"}]},{"type":"message","attributes":[{"key":"action","value":"execute"},{"key":"module","value":"wasm"},{"key":"sender","value":"link1twsfmuj28ndph54k4nw8crwu8h9c8mh3rtx705"}]},{"type":"wasm","attributes":[{"key":"contract_address","value":"link10pyejy66429refv3g35g2t7am0was7yaducgya"},{"key":"returned_pong","value":"42"},{"key":"returned_pong_with_struct","value":"hello world 101"},{"key":"returned_pong_with_tuple","value":"(hello world, 42)"},{"key":"returned_pong_with_tuple_takes_2_args","value":"(hello world, 42)"},{"key":"returned_contract_address","value":"link18vd8fpwxzck93qlwghaj6arh4p7c5n89fvcmzu"}]}]}]

@loloicci loloicci requested review from zemyblue and shiki-tak June 1, 2022 09:27
@loloicci loloicci marked this pull request as ready for review June 1, 2022 09:50
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jun 2, 2022
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 4a4e155 into Finschia:dynamic_link Jun 8, 2022
@loloicci loloicci deleted the return-tuple branch June 8, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants