Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix a error message for re-entrancy #200

Merged
merged 1 commit into from
Jun 8, 2022
Merged

fix: fix a error message for re-entrancy #200

merged 1 commit into from
Jun 8, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jun 2, 2022

Description

fix the error message for ReEntrancyError

Closes #193

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Jun 2, 2022
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jun 2, 2022
zemyblue
zemyblue approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit ea4ff2e into Finschia:dynamic_link Jun 8, 2022
@loloicci loloicci deleted the reentrancy-err-msg branch June 8, 2022 02:09
@loloicci loloicci mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @zemyblue @shiki-tak