Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve how to specify the callee contract address #215

Merged
merged 9 commits into from
Jul 6, 2022

Conversation

loloicci
Copy link
Contributor

Description

This PR changes how to specify the callee contract address in the caller contract.
For this purpose, it contains

  • Define the Contract trait that represents the callee contract
  • Implement a derive macro for Contract
  • Modify the VM code to change from where the contract address is fetched
  • Modify the dynamic_link macro

What is changed about the usage of the #[dynamic_link] macro is described in #207.

Closes #207

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Jun 30, 2022
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jun 30, 2022
Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loloicci
Copy link
Contributor Author

loloicci commented Jun 30, 2022

@tnasu

Would you fix the checks error?
https://github.com/line/cosmwasm/runs/7124425608?check_suite_focus=true

I checked them with integration tests and missed fixing some unit tests. Now I fixed and pushed.
Thank you for your check!

Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 4aa757d into Finschia:dynamic_link Jul 6, 2022
@loloicci loloicci deleted the improve-specifying-address branch July 6, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants