Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve dynamic link contracts' tests and add them to github workflow #221

Merged
merged 5 commits into from
Jul 21, 2022
Merged

feat: improve dynamic link contracts' tests and add them to github workflow #221

merged 5 commits into from
Jul 21, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jul 7, 2022

Description

This PR improves dynamic link contracts' tests and adds them to github workflow.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jul 7, 2022
@loloicci loloicci self-assigned this Jul 7, 2022
@loloicci loloicci force-pushed the fix-dynamic-link-tests branch 3 times, most recently from 1668925 to 63de67c Compare July 8, 2022 06:10
@loloicci loloicci marked this pull request as ready for review July 8, 2022 09:22
@zemyblue
Copy link
Member

zemyblue commented Jul 8, 2022

Please add the changelog about this PR if necessary.

@loloicci
Copy link
Contributor Author

loloicci commented Jul 8, 2022

@zemyblue

Please add the changelog about this PR if necessary.

In our repository, CHANGELOG will be edited when the version bumps. So I think it is unnecessary. Isn't it right?

@loloicci loloicci requested a review from zemyblue July 8, 2022 09:58
@zemyblue
Copy link
Member

zemyblue commented Jul 8, 2022

@zemyblue

Please add the changelog about this PR if necessary.

In our repository, CHANGELOG will be edited when the version bumps. So I think it is unnecessary. Isn't it right?

OK

shiki-tak
shiki-tak approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zemyblue
zemyblue approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 3857228 into Finschia:dynamic_link Jul 21, 2022
@loloicci loloicci deleted the fix-dynamic-link-tests branch July 21, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @zemyblue @shiki-tak