Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass env as the second arg of dynamic linked callee function #234

Merged
merged 7 commits into from
Sep 6, 2022
Merged

feat: pass env as the second arg of dynamic linked callee function #234

merged 7 commits into from
Sep 6, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Aug 26, 2022 •
edited
Loading

Description

This PR makes dynamic linked callee function takes Env as its second arg. And, this PR deletes GlobalApi. Passing env as the second argument is done in wasmvm (Finschia/wasmvm#74)

This is a breaking change and wasmvm needs to be changed following this change.

This PR will be rebased and force pushed after #233 and #229 are merged. rebased

Closes #213

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Aug 26, 2022
@loloicci loloicci added VM dynamic_link relate the dynamic link call feature and removed VM labels Aug 26, 2022
@loloicci loloicci marked this pull request as ready for review August 26, 2022 13:14
@loloicci loloicci mentioned this pull request Aug 26, 2022
Merged
8 tasks
@shiki-tak
Copy link
Contributor

I check this PR after rebase.

@loloicci
Copy link
Contributor Author

loloicci commented Sep 2, 2022

@shiki-tak rebased. please review!

I check this PR after rebase.

@loloicci loloicci merged commit d08b5a5 into dynamic_link Sep 6, 2022
@loloicci loloicci deleted the env-arg branch September 6, 2022 05:32
@loloicci loloicci mentioned this pull request Sep 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da1suk8 da1suk8 da1suk8 approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @shiki-tak @da1suk8