Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add Documentation tests #262

Merged
merged 4 commits into from
Dec 23, 2022
Merged

ci: add Documentation tests #262

merged 4 commits into from
Dec 23, 2022

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Dec 21, 2022 •
edited
Loading

Description

cargo test compile and execute unit tests, integration tests, and documentation tests.
FYI : https://doc.rust-lang.org/cargo/commands/cargo-test.html
Added Documentation tests not covered by ci.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@da1suk8 da1suk8 self-assigned this Dec 21, 2022
@da1suk8 da1suk8 changed the title ci: add Documentation tests in ci ci: add Documentation tests Dec 21, 2022
@da1suk8 da1suk8 marked this pull request as ready for review December 22, 2022 04:25
loloicci
loloicci approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@loloicci loloicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want new line in the tail of .cargo/config files. other than it, LGTM

@da1suk8 da1suk8 merged commit 202cb81 into Finschia:dynamic_link Dec 23, 2022
@da1suk8 da1suk8 deleted the ci/add_doc_test branch December 23, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@da1suk8 da1suk8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da1suk8 @shiki-tak @loloicci