Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a function to generate callee events from dynamic linked callee instance's event manager #269

Closed
wants to merge 5 commits into from
Closed

feat: add a function to generate callee events from dynamic linked callee instance's event manager #269

wants to merge 5 commits into from

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Feb 17, 2023 •
edited
Loading

Description

A part of the 3rd part of #265.

This PR adds a function to generate callee events from a dynamic linked callee instance's event manager. This function is for copy callee's event manager info to caller's event manager.

And, this PR also improve the events contract to useable as a dynamic linked contract. This contract is used by tests implemented in wasmvm's PR.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci
feat: implement generate_events_as_from_dynamic_linked_callee to Inst…
9e35169 
…ance

This commit implements generate_events_as_from_dynamic_linked_calleeto
Instance.
This function is for generate event manager's info which will be copied
from callee instance to caller instance.
@loloicci
test: add test for generate_events_as_from_dynamic_linked_callee
0ac9970
@loloicci
feat: improve events contract usable for callee/caller
1684170
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Feb 17, 2023
@loloicci loloicci self-assigned this Feb 17, 2023
This was referenced Feb 17, 2023
Closed
Closed
@loloicci
Copy link
Contributor Author

Closed via #273
(generate callee events function will be removed and update event contract will be merged with another contract)

@loloicci loloicci closed this Mar 27, 2023
@loloicci loloicci mentioned this pull request Mar 27, 2023
Merged
8 tasks
@loloicci loloicci deleted the dynamic-event-manager branch April 20, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da1suk8 da1suk8 da1suk8 approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loloicci @da1suk8