feat: switch how to do dynamic link and validate interface to solve rust/Go pointer sharing issue #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
force-pushed
the
rust-go-pointer-api
branch
from
b65df3a
to
1d4448c
Compare
loloicci
force-pushed
the
rust-go-pointer-api
branch
from
1d4448c
to
245e750
Compare
13 tasks
da1suk8
reviewed
Apr 11, 2023
|
I think it is better to remove the |
Kynea0b
approved these changes
Apr 11, 2023
some tests in vm/dynamic_link.rs are testing mock.rs's call_callable point. this is verbose, and this mock will be removed in Finschia#273. so this commit removes these tests.
da1suk8
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of #273 and switches how to do dynamic link and validate interfaces for other contracts. After merging this, the
GetContractEnvand theGetWasmerModuleAPIs will not be used in the wasm module.This PR also improves some contracts used by integration tests.
Types of changes
Checklist