Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add lack clippy tests for some contracts and fix contracts according to them #285

Merged
merged 8 commits into from
Apr 11, 2023
Merged

ci: add lack clippy tests for some contracts and fix contracts according to them #285

merged 8 commits into from
Apr 11, 2023

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Apr 10, 2023 •
edited
Loading

Description

Closes #284

This PR adds clippy tests for contracts to ci and fixes contracts according to them.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Apr 10, 2023
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Apr 10, 2023
@loloicci loloicci changed the title ci: add lack clippy tests for some contracts ci: add lack clippy tests for some contracts and fix contracts according them Apr 11, 2023
@loloicci loloicci changed the title ci: add lack clippy tests for some contracts and fix contracts according them ci: add lack clippy tests for some contracts and fix contracts according to them Apr 11, 2023
@loloicci loloicci merged commit f3d7757 into Finschia:dynamic_link Apr 11, 2023
@loloicci loloicci deleted the ci-clippy branch April 11, 2023 06:58
@loloicci loloicci mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kynea0b Kynea0b Kynea0b approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @da1suk8 @Kynea0b