Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serde wasm32 target #288

Merged

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Apr 18, 2023

Description

The cosmwasm_std::{to_vec, from_slice} were implemented using to serde_json_wasm::{to_vec, from_slice}. If it isn't a WASM target, using those functions may cause problems.

contracts, packages/std are wasm targets and packages/derive, packages/storage have a dependency on contracts.
packages/vm is not a wasm target.

So the change in this PR is to change the part of packages/vm that uses cosmwasm_std::{to_vec, from_slice} to serde_json based.

Closes #277

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@dudong2 dudong2 self-assigned this Apr 18, 2023
@dudong2 dudong2 added the bug Something isn't working label Apr 18, 2023
@dudong2 dudong2 marked this pull request as ready for review April 18, 2023 18:22
@dudong2 dudong2 requested a review from loloicci April 20, 2023 01:02
Copy link
Contributor

@loloicci loloicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@loloicci loloicci self-requested a review April 20, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants