Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: write explanatory comments on test functions in the sample contract #318

Merged
merged 3 commits into from
Jul 21, 2023
Merged

chore: write explanatory comments on test functions in the sample contract #318

merged 3 commits into from
Jul 21, 2023

Conversation

170210
Copy link
Contributor

@170210 170210 commented Jul 14, 2023 •
edited
Loading

Description

This PR has following changes.

  • write explanatory comments on test functions in the sample contract

Closes #317

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@170210 170210 marked this pull request as ready for review July 14, 2023 09:51
@170210 170210 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 14, 2023
@170210 170210 self-assigned this Jul 14, 2023
@170210 170210 changed the title docs: write explanatory comments on the query_* function in the sample contract docs: write explanatory comments on test functions in the sample contract Jul 14, 2023
loloicci
loloicci previously approved these changes Jul 18, 2023
View reviewed changes
@loloicci
Copy link
Contributor

change the proof.proto path to third_party/proto/confio

Please fix the description of this PR. (maybe mistake)

@loloicci loloicci self-requested a review July 18, 2023 01:52
Kynea0b
Kynea0b previously approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the title prefix. Sorry for the late review. Is comment: better?

@zemyblue
Copy link
Member

Please use chore: structural elements.

da1suk8
da1suk8 reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@da1suk8 da1suk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit detailed, but I feel that "panic" makes it seem as if a panic is occurring, so it would be helpful if you could correct it to say that an error is occurring.

@170210 170210 changed the title docs: write explanatory comments on test functions in the sample contract chore: write explanatory comments on test functions in the sample contract Jul 20, 2023
@170210
chore: write explanatory comments on test functions
6b81071 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 dismissed stale reviews from Kynea0b and loloicci via 6b81071 July 21, 2023 06:10
@170210
style: format
e312f40 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested review from Kynea0b and da1suk8 July 21, 2023 07:13
da1suk8
da1suk8 previously approved these changes Jul 21, 2023
View reviewed changes
loloicci
loloicci suggested changes Jul 21, 2023
View reviewed changes
contracts/call-number/src/contract.rs Outdated Show resolved Hide resolved
contracts/call-number/src/contract.rs Outdated Show resolved Hide resolved
contracts/call-number/src/contract.rs Outdated Show resolved Hide resolved
@170210
style: fix for review
0ee9dde 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from loloicci July 21, 2023 07:25
@da1suk8 da1suk8 self-requested a review July 21, 2023 07:33
@170210 170210 merged commit db08495 into Finschia:dynamic_link Jul 21, 2023
30 checks passed
@170210 170210 deleted the fix/document branch July 21, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

Assignees

@170210 170210

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@170210 @CLAassistant @loloicci @zemyblue @da1suk8 @Kynea0b