Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade yarn3 to yarn1 #99

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Downgrade yarn3 to yarn1 #99

merged 6 commits into from
Aug 1, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Jul 31, 2023

Description

While yarn3 have all the dependencies, we need to upload all the dependencies to lfs storage.
but currently lfs storage's bandwidth exceeded free plan so we are going to change not to use lfs storage.

In this PR, yarn3 change to yarn1 not to contain all the dependencies and untrack all the lfs files.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 requested review from zemyblue, 0Tech and jaeseung-bae July 31, 2023 04:22
@loin3 loin3 self-assigned this Jul 31, 2023
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the wasm files changed?

@loin3
Copy link
Contributor Author

loin3 commented Jul 31, 2023

because wasm files are untracked as lfs and track again as normal file.

@loin3 loin3 requested a review from zemyblue July 31, 2023 07:02
zemyblue
zemyblue previously approved these changes Jul 31, 2023
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update changelog??

@loin3 loin3 requested review from jaeseung-bae and zemyblue August 1, 2023 01:49
@loin3 loin3 merged commit 174ed42 into main Aug 1, 2023
@loin3 loin3 deleted the downgrade_yarn1 branch August 1, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants