Skip to content

feat: add role-based access control for bridge (backport #1358) #4265

feat: add role-based access control for bridge (backport #1358)

feat: add role-based access control for bridge (backport #1358) #4265

Triggered via pull request May 7, 2024 12:46
Status Failure
Total duration 1m 6s
Artifacts

lint.yml

on: pull_request
golangci-lint
53s
golangci-lint
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
golangci-lint: x/fbridge/module/module.go#L1
: # github.com/Finschia/finschia-sdk/x/fbridge/module
golangci-lint: x/fbridge/module/module.go#L30
cannot use AppModule{} (value of type AppModule) as "github.com/Finschia/finschia-sdk/types/module".BeginBlockAppModule value in variable declaration: AppModule does not implement "github.com/Finschia/finschia-sdk/types/module".BeginBlockAppModule (wrong type for method BeginBlock)
golangci-lint: simapp/app.go#L71
could not import github.com/Finschia/finschia-sdk/x/fbridge/module (-: # github.com/Finschia/finschia-sdk/x/fbridge/module
golangci-lint: x/fbridge/module/module.go#L30
cannot use AppModule{} (value of type AppModule) as "github.com/Finschia/finschia-sdk/types/module".BeginBlockAppModule value in variable declaration: AppModule does not implement "github.com/Finschia/finschia-sdk/types/module".BeginBlockAppModule (wrong type for method BeginBlock)
golangci-lint: x/fbridge/keeper/auth.go#L95
`if` block ends with a `return` statement, so drop this `else` and outdent its block (golint)
golangci-lint
issues found
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4.0.1, actions/checkout@v3, technote-space/get-diff-action@v6.1.2, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
golangci-lint
Restore cache failed: Dependencies file is not found in /home/runner/work/finschia-sdk/finschia-sdk. Supported file pattern: go.sum