chore: apply comment

Finschia · Mar 29, 2021 · 34b5d90 · 34b5d90
1 parent 99a776f
commit 34b5d90
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 28 deletions.
diff --git a/.releaserc b/.releaserc
diff --git a/errors/errors.go b/errors/errors.go
diff --git a/x/coin/internal/types/errors.go b/x/coin/internal/types/errors.go
@@ -13,4 +13,5 @@ var (
 	ErrSendDisabled                = sdkerrors.Register(Codespace, 4, "send transactions are disabled")
 	ErrCanNotTransferToBlacklisted = sdkerrors.Register(Codespace, 5, "Cannot transfer to safety box addresses")
 	ErrRequestGetsLimit            = sdkerrors.Register(Codespace, 6, "the gets should be limited")
+	ErrInvalidDenom                = sdkerrors.Register(Codespace, 7, "invalid denom")
 )
diff --git a/x/coin/internal/types/msgs.go b/x/coin/internal/types/msgs.go
@@ -3,7 +3,6 @@ package types
 import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
-	"github.com/line/lbm-sdk/v2/errors"
 )
 
 const RouterKey = ModuleName
@@ -196,7 +195,7 @@ func ValidateInputsOutputs(inputs []Input, outputs []Output) error {
 func validateDenomination(coins sdk.Coins) error {
 	for _, coin := range coins {
 		if err := ValidateSymbolReserved(coin.Denom); err != nil {
-			return sdkerrors.Wrapf(errors.ErrInvalidDenom, "invalid denom [%s] send message supports 3~5 length denom only", coin.Denom)
+			return sdkerrors.Wrapf(ErrInvalidDenom, "invalid denom [%s] send message supports 3~5 length denom only", coin.Denom)
 		}
 	}
 	return nil

diff --git a/x/collection/internal/types/errors.go b/x/collection/internal/types/errors.go
@@ -52,6 +52,7 @@ var (
 	ErrCompositionTooDeep            = sdkerrors.Register(ModuleName, 45, "cannot attach token (composition too deep)")
 	ErrCompositionTooWide            = sdkerrors.Register(ModuleName, 46, "cannot attach token (composition too wide)")
 	ErrBurnNonRootNFT                = sdkerrors.Register(ModuleName, 47, "cannot burn non-root NFTs")
+	ErrInvalidPermissionAction       = sdkerrors.Register(ModuleName, 48, "invalid permission action")
 )
 
 func WrapIfOverflowPanic(r interface{}) error {

diff --git a/x/collection/internal/types/msgs_perm.go b/x/collection/internal/types/msgs_perm.go
@@ -6,7 +6,6 @@ import (
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
-	"github.com/line/lbm-sdk/v2/errors"
 	"github.com/line/lbm-sdk/v2/x/contract"
 )
 
@@ -91,5 +90,6 @@ func validateAction(action string, actions ...string) error {
 			return nil
 		}
 	}
-	return sdkerrors.Wrap(errors.ErrInvalidPermission, fmt.Sprintf("permission should be one of [%s]", strings.Join(actions, ",")))
+	return sdkerrors.Wrap(ErrInvalidPermissionAction,
+		fmt.Sprintf("permission action should be one of [%s]", strings.Join(actions, ",")))
 }
diff --git a/x/token/internal/types/errors.go b/x/token/internal/types/errors.go
@@ -29,6 +29,7 @@ var (
 	ErrApproverProxySame        = sdkerrors.Register(ModuleName, 22, "approver is same with proxy")
 	ErrTokenNotApproved         = sdkerrors.Register(ModuleName, 23, "proxy is not approved on the token")
 	ErrTokenAlreadyApproved     = sdkerrors.Register(ModuleName, 24, "proxy is already approved on the token")
+	ErrInvalidPermissionAction  = sdkerrors.Register(ModuleName, 25, "invalid permission action")
 )
 
 func WrapIfOverflowPanic(r interface{}) error {

diff --git a/x/token/internal/types/msgs_perm.go b/x/token/internal/types/msgs_perm.go
@@ -6,7 +6,6 @@ import (
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
-	"github.com/line/lbm-sdk/v2/errors"
 	"github.com/line/lbm-sdk/v2/x/contract"
 )
 
@@ -91,5 +90,6 @@ func validateAction(action string, actions ...string) error {
 			return nil
 		}
 	}
-	return sdkerrors.Wrap(errors.ErrInvalidPermission, fmt.Sprintf("permission should be one of [%s]", strings.Join(actions, ",")))
+	return sdkerrors.Wrap(ErrInvalidPermissionAction,
+		fmt.Sprintf("permission action should be one of [%s]", strings.Join(actions, ",")))
 }