chore: remove ChanCheckTxSize and RPCIdleTimeout settings

Finschia · Nov 20, 2023 · 8fd88a0 · 8fd88a0
1 parent dc2ff66
commit 8fd88a0
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 23 deletions.
diff --git a/server/config/config.go b/server/config/config.go
@@ -24,9 +24,6 @@ const (
 	// DefaultGRPCWebAddress defines the default address to bind the gRPC-web server to.
 	DefaultGRPCWebAddress = "0.0.0.0:9091"
 
-	// DefaultChanCheckTxSize defines the default size of channel check tx in Baseapp
-	DefaultChanCheckTxSize = 10000
-
 	// DefaultGRPCMaxRecvMsgSize defines the default gRPC max message size in
 	// bytes the server can receive.
 	DefaultGRPCMaxRecvMsgSize = 1024 * 1024 * 10
@@ -96,9 +93,6 @@ type BaseConfig struct {
 	// When true, Prometheus metrics are served under /metrics on prometheus_listen_addr in config.toml.
 	// It works when tendermint's prometheus option (config.toml) is set to true.
 	Prometheus bool `mapstructure:"prometheus"`
-
-	// ChanCheckTxSize is the size of RequestCheckTxAsync of BaseApp
-	ChanCheckTxSize uint `mapstructure:"chan-check-tx-size"`
 }
 
 // APIConfig defines the API listener configuration.
@@ -124,9 +118,6 @@ type APIConfig struct {
 	// RPCWriteTimeout defines the Tendermint RPC write timeout (in seconds)
 	RPCWriteTimeout uint `mapstructure:"rpc-write-timeout"`
 
-	// RPCIdleTimeout defines the Tendermint RPC idle timeout (in seconds)
-	RPCIdleTimeout uint `mapstructure:"rpc-idle-timeout"`
-
 	// RPCMaxBodyBytes defines the Tendermint maximum response body (in bytes)
 	RPCMaxBodyBytes uint `mapstructure:"rpc-max-body-bytes"`
 
@@ -253,7 +244,6 @@ func DefaultConfig() *Config {
 			InterBlockCacheSize: cache.DefaultCommitKVStoreCacheSize,
 			IAVLCacheSize:       iavl.DefaultIAVLCacheSize,
 			IAVLDisableFastNode: true,
-			ChanCheckTxSize:     DefaultChanCheckTxSize,
 		},
 		Telemetry: telemetry.Config{
 			Enabled:      false,
@@ -266,7 +256,6 @@ func DefaultConfig() *Config {
 			MaxOpenConnections: 1000,
 			RPCReadTimeout:     10,
 			RPCWriteTimeout:    10,
-			RPCIdleTimeout:     60,
 			RPCMaxBodyBytes:    1000000,
 		},
 		GRPC: GRPCConfig{
@@ -326,7 +315,6 @@ func GetConfig(v *viper.Viper) (Config, error) {
 			MinRetainBlocks:     v.GetUint64("min-retain-blocks"),
 			IAVLDisableFastNode: v.GetBool("iavl-disable-fastnode"),
 			IAVLCacheSize:       v.GetUint64("iavl-cache-size"),
-			ChanCheckTxSize:     v.GetUint("chan-check-tx-size"),
 		},
 		Telemetry: telemetry.Config{
 			ServiceName:             v.GetString("telemetry.service-name"),
@@ -344,7 +332,6 @@ func GetConfig(v *viper.Viper) (Config, error) {
 			MaxOpenConnections: v.GetUint("api.max-open-connections"),
 			RPCReadTimeout:     v.GetUint("api.rpc-read-timeout"),
 			RPCWriteTimeout:    v.GetUint("api.rpc-write-timeout"),
-			RPCIdleTimeout:     v.GetUint("api.rpc-idle-timeout"),
 			RPCMaxBodyBytes:    v.GetUint("api.rpc-max-body-bytes"),
 			EnableUnsafeCORS:   v.GetBool("api.enabled-unsafe-cors"),
 		},

diff --git a/server/config/toml.go b/server/config/toml.go
@@ -86,10 +86,6 @@ index-events = {{ .BaseConfig.IndexEvents }}
 # It works when tendermint's prometheus option (config.toml) is set to true.
 prometheus = {{ .BaseConfig.Prometheus }}
 
-# ChanCheckTxSize is the size of RequestCheckTxAsync of BaseApp.
-# ChanCheckTxSize should be equals to or greater than the mempool size set in config.toml of tendermint.
-chan-check-tx-size = {{ .BaseConfig.ChanCheckTxSize }}
-
 ###############################################################################
 ###                         Telemetry Configuration                         ###
 ###############################################################################
@@ -149,9 +145,6 @@ rpc-read-timeout = {{ .API.RPCReadTimeout }}
 # RPCWriteTimeout defines the tendermint RPC write timeout (in seconds).
 rpc-write-timeout = {{ .API.RPCWriteTimeout }}
 
-# RPCIdleTimeout defines the tendermint RPC idle timeout (in seconds).
-rpc-idle-timeout = {{ .API.RPCIdleTimeout }}
-
 # RPCMaxBodyBytes defines the tendermint maximum response body (in bytes).
 rpc-max-body-bytes = {{ .API.RPCMaxBodyBytes }}
 

diff --git a/server/start.go b/server/start.go
@@ -53,7 +53,6 @@ const (
 	FlagTrace               = "trace"
 	FlagInvCheckPeriod      = "inv-check-period"
 	FlagPrometheus          = "prometheus"
-	FlagChanCheckTxSize     = "chan-check-tx-size"
 
 	FlagPruning           = "pruning"
 	FlagPruningKeepRecent = "pruning-keep-recent"
@@ -183,8 +182,6 @@ is performed. Note, when enabled, gRPC will also be automatically enabled.
 
 	cmd.Flags().Bool(FlagPrometheus, false, "Enable prometheus metric for app")
 
-	cmd.Flags().Uint(FlagChanCheckTxSize, serverconfig.DefaultChanCheckTxSize, "The size of the channel check tx")
-
 	// add support for all Tendermint-specific command line options
 	tmcmd.AddNodeFlags(cmd)
 	return cmd