chore: caching paramset (#198)

* chore: implement cache for param set

* chore: caching copied object

* fix: invalidate cached param set when it's field is updated

* chore: implement Subspace pointer receiver

* fix: modify cache method

* chore: fix lint error

* chore: fix lint error

* chore: add comment about concurrency of cache functions

simapp/app.go

@@ -526,7 +526,7 @@ func (app *SimApp) GetMemKey(storeKey string) *sdk.MemoryStoreKey {
 // GetSubspace returns a param subspace for a given module name.
 //
 // NOTE: This is solely to be used for testing purposes.
-func (app *SimApp) GetSubspace(moduleName string) paramstypes.Subspace {
+func (app *SimApp) GetSubspace(moduleName string) *paramstypes.Subspace {
 	subspace, _ := app.ParamsKeeper.GetSubspace(moduleName)
 	return subspace
 }

x/auth/keeper/keeper.go

@@ -49,7 +49,7 @@ type AccountKeeperI interface {
 type AccountKeeper struct {
 	key           sdk.StoreKey
 	cdc           codec.BinaryMarshaler
-	paramSubspace paramtypes.Subspace
+	paramSubspace *paramtypes.Subspace
 	permAddrs     map[string]types.PermissionsForAddress
 
 	// The prototypical AccountI constructor.
@@ -61,7 +61,7 @@ var _ AccountKeeperI = &AccountKeeper{}
 // NewAccountKeeper returns a new AccountKeeperI that uses go-amino to
 // (binary) encode and decode concrete sdk.Accounts.
 func NewAccountKeeper(
-	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramstore paramtypes.Subspace, proto func() types.AccountI,
+	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramstore *paramtypes.Subspace, proto func() types.AccountI,
 	maccPerms map[string][]string,
 ) AccountKeeper {
 

x/bank/keeper/grpc_query_test.go

@@ -118,7 +118,9 @@ func (suite *IntegrationTestSuite) TestQueryParams() {
 	res, err := suite.queryClient.Params(gocontext.Background(), &types.QueryParamsRequest{})
 	suite.Require().NoError(err)
 	suite.Require().NotNil(res)
-	suite.Require().Equal(suite.app.BankKeeper.GetParams(suite.ctx), res.GetParams())
+	param := suite.app.BankKeeper.GetParams(suite.ctx)
+	suite.Require().Equal(len(param.SendEnabled), len(res.GetParams().SendEnabled))
+	suite.Require().Equal(param.DefaultSendEnabled, res.GetParams().DefaultSendEnabled)
 }
 
 func (suite *IntegrationTestSuite) QueryDenomsMetadataRequest() {

x/bank/keeper/keeper.go

@@ -54,11 +54,11 @@ type BaseKeeper struct {
 	ak         types.AccountKeeper
 	cdc        codec.BinaryMarshaler
 	storeKey   sdk.StoreKey
-	paramSpace paramtypes.Subspace
+	paramSpace *paramtypes.Subspace
 }
 
 func NewBaseKeeper(
-	cdc codec.BinaryMarshaler, storeKey sdk.StoreKey, ak types.AccountKeeper, paramSpace paramtypes.Subspace,
+	cdc codec.BinaryMarshaler, storeKey sdk.StoreKey, ak types.AccountKeeper, paramSpace *paramtypes.Subspace,
 	blockedAddrs map[string]bool,
 ) BaseKeeper {
 

x/bank/keeper/send.go

@@ -43,14 +43,14 @@ type BaseSendKeeper struct {
 	cdc        codec.BinaryMarshaler
 	ak         types.AccountKeeper
 	storeKey   sdk.StoreKey
-	paramSpace paramtypes.Subspace
+	paramSpace *paramtypes.Subspace
 
 	// list of addresses that are restricted from receiving transactions
 	blockedAddrs map[string]bool
 }
 
 func NewBaseSendKeeper(
-	cdc codec.BinaryMarshaler, storeKey sdk.StoreKey, ak types.AccountKeeper, paramSpace paramtypes.Subspace, blockedAddrs map[string]bool,
+	cdc codec.BinaryMarshaler, storeKey sdk.StoreKey, ak types.AccountKeeper, paramSpace *paramtypes.Subspace, blockedAddrs map[string]bool,
 ) BaseSendKeeper {
 
 	return BaseSendKeeper{

x/crisis/keeper/keeper.go

@@ -14,7 +14,7 @@ import (
 // Keeper - crisis keeper
 type Keeper struct {
 	routes         []types.InvarRoute
-	paramSpace     paramtypes.Subspace
+	paramSpace     *paramtypes.Subspace
 	invCheckPeriod uint
 
 	supplyKeeper types.SupplyKeeper
@@ -24,7 +24,7 @@ type Keeper struct {
 
 // NewKeeper creates a new Keeper object
 func NewKeeper(
-	paramSpace paramtypes.Subspace, invCheckPeriod uint, supplyKeeper types.SupplyKeeper,
+	paramSpace *paramtypes.Subspace, invCheckPeriod uint, supplyKeeper types.SupplyKeeper,
 	feeCollectorName string,
 ) Keeper {
 

x/distribution/keeper/keeper.go

@@ -16,7 +16,7 @@ import (
 type Keeper struct {
 	storeKey      sdk.StoreKey
 	cdc           codec.BinaryMarshaler
-	paramSpace    paramtypes.Subspace
+	paramSpace    *paramtypes.Subspace
 	authKeeper    types.AccountKeeper
 	bankKeeper    types.BankKeeper
 	stakingKeeper types.StakingKeeper
@@ -28,7 +28,7 @@ type Keeper struct {
 
 // NewKeeper creates a new distribution Keeper instance
 func NewKeeper(
-	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace paramtypes.Subspace,
+	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace *paramtypes.Subspace,
 	ak types.AccountKeeper, bk types.BankKeeper, sk types.StakingKeeper,
 	feeCollectorName string, blockedAddrs map[string]bool,
 ) Keeper {

x/ibc/applications/transfer/keeper/keeper.go

@@ -21,7 +21,7 @@ import (
 type Keeper struct {
 	storeKey   sdk.StoreKey
 	cdc        codec.BinaryMarshaler
-	paramSpace paramtypes.Subspace
+	paramSpace *paramtypes.Subspace
 
 	channelKeeper types.ChannelKeeper
 	portKeeper    types.PortKeeper
@@ -32,7 +32,7 @@ type Keeper struct {
 
 // NewKeeper creates a new IBC transfer Keeper instance
 func NewKeeper(
-	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace paramtypes.Subspace,
+	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace *paramtypes.Subspace,
 	channelKeeper types.ChannelKeeper, portKeeper types.PortKeeper,
 	authKeeper types.AccountKeeper, bankKeeper types.BankKeeper, scopedKeeper capabilitykeeper.ScopedKeeper,
 ) Keeper {

x/ibc/core/02-client/keeper/keeper.go

@@ -26,12 +26,12 @@ import (
 type Keeper struct {
 	storeKey      sdk.StoreKey
 	cdc           codec.BinaryMarshaler
-	paramSpace    paramtypes.Subspace
+	paramSpace    *paramtypes.Subspace
 	stakingKeeper types.StakingKeeper
 }
 
 // NewKeeper creates a new NewKeeper instance
-func NewKeeper(cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace paramtypes.Subspace, sk types.StakingKeeper) Keeper {
+func NewKeeper(cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace *paramtypes.Subspace, sk types.StakingKeeper) Keeper {
 	// set KeyTable if it has not already been set
 	if !paramSpace.HasKeyTable() {
 		paramSpace = paramSpace.WithKeyTable(types.ParamKeyTable())

x/ibc/core/keeper/keeper.go

@@ -32,7 +32,7 @@ type Keeper struct {
 
 // NewKeeper creates a new ibc Keeper
 func NewKeeper(
-	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace paramtypes.Subspace,
+	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace *paramtypes.Subspace,
 	stakingKeeper clienttypes.StakingKeeper, scopedKeeper capabilitykeeper.ScopedKeeper,
 ) *Keeper {
 	clientKeeper := clientkeeper.NewKeeper(cdc, key, paramSpace, stakingKeeper)

x/mint/keeper/keeper.go

@@ -13,15 +13,15 @@ import (
 type Keeper struct {
 	cdc              codec.BinaryMarshaler
 	storeKey         sdk.StoreKey
-	paramSpace       paramtypes.Subspace
+	paramSpace       *paramtypes.Subspace
 	stakingKeeper    types.StakingKeeper
 	bankKeeper       types.BankKeeper
 	feeCollectorName string
 }
 
 // NewKeeper creates a new mint Keeper instance
 func NewKeeper(
-	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace paramtypes.Subspace,
+	cdc codec.BinaryMarshaler, key sdk.StoreKey, paramSpace *paramtypes.Subspace,
 	sk types.StakingKeeper, ak types.AccountKeeper, bk types.BankKeeper,
 	feeCollectorName string,
 ) Keeper {

x/params/keeper/grpc_query_test.go

@@ -12,7 +12,7 @@ func (suite *KeeperTestSuite) TestGRPCQueryParams() {
 	var (
 		req      *proposal.QueryParamsRequest
 		expValue string
-		space    types.Subspace
+		space    *types.Subspace
 	)
 	key := []byte("key")
 

x/params/keeper/keeper.go

@@ -35,7 +35,7 @@ func (k Keeper) Logger(ctx sdk.Context) log.Logger {
 }
 
 // Allocate subspace used for keepers
-func (k Keeper) Subspace(s string) types.Subspace {
+func (k Keeper) Subspace(s string) *types.Subspace {
 	_, ok := k.spaces[s]
 	if ok {
 		panic("subspace already occupied")
@@ -46,16 +46,16 @@ func (k Keeper) Subspace(s string) types.Subspace {
 	}
 
 	space := types.NewSubspace(k.cdc, k.legacyAmino, k.key, k.tkey, s)
-	k.spaces[s] = &space
+	k.spaces[s] = space
 
 	return space
 }
 
 // Get existing substore from keeper
-func (k Keeper) GetSubspace(s string) (types.Subspace, bool) {
+func (k Keeper) GetSubspace(s string) (*types.Subspace, bool) {
 	space, ok := k.spaces[s]
 	if !ok {
-		return types.Subspace{}, false
+		return &types.Subspace{}, false
 	}
-	return *space, ok
+	return space, ok
 }