fix: Add a test to manage the parameter MaxWasmCodeSize with gov (#51)

* refactoring: use var defined in types as expected default value of wasm parameters * add test for change the parameter MaxWasmCodeSize * Add documentation
Finschia · Dec 4, 2020 · f7be553 · f7be553
1 parent c553ff6
commit f7be553
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/x/wasm/Governance.md b/x/wasm/Governance.md
@@ -19,6 +19,13 @@ For details see the proposal type [implementation](https://github.com/CosmWasm/w
 A wasm message but no proposal type: 
 * `ExecuteContract` - execute a command on a wasm contract
 
+And you can use `Parameter Change Proposal` to change wasm parameters.
+These parameters are as following.
+
+* `UploadAccess` - who can upload wasm codes
+* `DefaultInstantiatePermission` - who can instantiate contracts from a code in default
+* `MaxWasmCodeSize` - max size of wasm code to be uploaded
+
 ### Unit tests
 [Proposal type validations](https://github.com/CosmWasm/wasmd/blob/master/x/wasm/internal/types/proposal_test.go)
 

diff --git a/x/wasm/internal/keeper/proposal_integration_test.go b/x/wasm/internal/keeper/proposal_integration_test.go
@@ -314,12 +314,15 @@ func TestUpdateParamsProposal(t *testing.T) {
 		cdc                                   = keepers.WasmKeeper.cdc
 		myAddress              sdk.AccAddress = make([]byte, sdk.AddrLen)
 		oneAddressAccessConfig                = types.OnlyAddress.With(myAddress)
+		newMaxWasmCodeSize                    = uint64(42)
+		defaultParams                         = types.DefaultParams()
 	)
 
 	specs := map[string]struct {
 		src                params.ParamChange
 		expUploadConfig    types.AccessConfig
 		expInstantiateType types.AccessType
+		expMaxWasmCodeSize uint64
 	}{
 		"update upload permission param": {
 			src: params.ParamChange{
@@ -328,7 +331,8 @@ func TestUpdateParamsProposal(t *testing.T) {
 				Value:    string(cdc.MustMarshalJSON(&types.AllowNobody)),
 			},
 			expUploadConfig:    types.AllowNobody,
-			expInstantiateType: types.Everybody,
+			expInstantiateType: defaultParams.DefaultInstantiatePermission,
+			expMaxWasmCodeSize: defaultParams.MaxWasmCodeSize,
 		},
 		"update upload permission param with address": {
 			src: params.ParamChange{
@@ -337,16 +341,28 @@ func TestUpdateParamsProposal(t *testing.T) {
 				Value:    string(cdc.MustMarshalJSON(&oneAddressAccessConfig)),
 			},
 			expUploadConfig:    oneAddressAccessConfig,
-			expInstantiateType: types.Everybody,
+			expInstantiateType: defaultParams.DefaultInstantiatePermission,
+			expMaxWasmCodeSize: defaultParams.MaxWasmCodeSize,
 		},
 		"update instantiate param": {
 			src: params.ParamChange{
 				Subspace: types.DefaultParamspace,
 				Key:      string(types.ParamStoreKeyInstantiateAccess),
 				Value:    string(cdc.MustMarshalJSON(types.Nobody)),
 			},
-			expUploadConfig:    types.AllowEverybody,
+			expUploadConfig:    defaultParams.UploadAccess,
 			expInstantiateType: types.Nobody,
+			expMaxWasmCodeSize: defaultParams.MaxWasmCodeSize,
+		},
+		"update max wasm code size": {
+			src: params.ParamChange{
+				Subspace: types.DefaultParamspace,
+				Key:      string(types.ParamStoreKeyMaxWasmCodeSize),
+				Value:    string(cdc.MustMarshalJSON(newMaxWasmCodeSize)),
+			},
+			expUploadConfig:    defaultParams.UploadAccess,
+			expInstantiateType: defaultParams.DefaultInstantiatePermission,
+			expMaxWasmCodeSize: newMaxWasmCodeSize,
 		},
 	}
 	for msg, spec := range specs {
@@ -372,6 +388,7 @@ func TestUpdateParamsProposal(t *testing.T) {
 			assert.True(t, spec.expUploadConfig.Equals(wasmKeeper.getUploadAccessConfig(ctx)),
 				"got %#v not %#v", wasmKeeper.getUploadAccessConfig(ctx), spec.expUploadConfig)
 			assert.Equal(t, spec.expInstantiateType, wasmKeeper.getInstantiateAccessConfig(ctx))
+			assert.Equal(t, spec.expMaxWasmCodeSize, wasmKeeper.GetMaxWasmCodeSize(ctx))
 		})
 	}
 }