Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not supporting MsgMultiSend of x/bank #868

Closed
4 tasks
zemyblue opened this issue Jan 26, 2023 · 0 comments · Fixed by #876
Closed
4 tasks

Not supporting MsgMultiSend of x/bank #868

zemyblue opened this issue Jan 26, 2023 · 0 comments · Fixed by #876
Assignees
@tkxkd0159
Labels
C:x/bankplus
Milestone
v0.47.0

Comments

@zemyblue
Copy link
Member

Summary

Disable MsgMultiSend of x/bank

Problem Definition

When sending coin with MsgMultiSend, we can make sure that the source of the amount you are sending cannot be clearly identified. And MsgMultiSend can be replaced with MultiMsg txs. Cosmos-SDK is also trying to change to single signer at cosmos/cosmos-sdk issues/12628. So, it would be better to disable it for now and apply the changed function when it is stabilized later in Cosmos-SDK so that it can be used.

Proposal

Let's return an error if use MsgMultiSend in the x/bankplus. And use x/bankplus instead of x/bank as default.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tkxkd0159 tkxkd0159 self-assigned this Feb 1, 2023
@tkxkd0159 tkxkd0159 mentioned this issue Feb 2, 2023
Merged
5 tasks
@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkxkd0159 tkxkd0159

Labels
C:x/bankplus
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging a pull request may close this issue.

feat!: add MultiSend deactivation tkxkd0159/finschia-sdk
2 participants
@zemyblue @tkxkd0159