-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add MultiSend deactivation #876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
requested review from
zemyblue,
0Tech,
dudong2,
loin3 and
jaeseung-bae
February 2, 2023 03:59
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 62.37% 62.37% -0.01%
==========================================
Files 653 653
Lines 79976 79985 +9
==========================================
+ Hits 49885 49890 +5
- Misses 27399 27402 +3
- Partials 2692 2693 +1
|
0Tech
reviewed
Feb 3, 2023
dudong2
approved these changes
Feb 3, 2023
0Tech
approved these changes
Feb 6, 2023
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Feb 6, 2023
* main: feat!: add MultiSend deactivation (Finschia#876) chore(deps): Bump github.com/gogo/protobuf in /ics23/go (Finschia#816) fix: do not create account on x/token,collection (Finschia#866) fix!: update x/collection,token proto (Finschia#863) # Conflicts: # CHANGELOG.md
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #868
Activate this feature on bankpluskeeper directly instead of using config. Because this feature is not supposed to change by an outside party. It need to use intentionally when build an App instance.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml