Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the logic of the Challenge query #1002

Closed

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented May 12, 2023

Description

The goal of phase 1 is applying cannon@0.2.0 to Finschia purely as possible. This PR implement the logic of the Challenge query.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@ulbqb ulbqb self-assigned this May 12, 2023
@ulbqb ulbqb force-pushed the feat/settlement_challenge_query branch 2 times, most recently from bf027b0 to 4140fc0 Compare May 12, 2023 08:21
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (for-ramus@e424237). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head add6204 differs from pull request most recent head d764401. Consider uploading reports for the commit d764401 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             for-ramus    #1002   +/-   ##
============================================
  Coverage             ?   61.87%           
============================================
  Files                ?      681           
  Lines                ?    79361           
  Branches             ?        0           
============================================
  Hits                 ?    49105           
  Misses               ?    27560           
  Partials             ?     2696           

@ulbqb ulbqb force-pushed the feat/settlement_challenge_query branch 3 times, most recently from 2e66c71 to 0d01885 Compare May 12, 2023 09:06
@ulbqb ulbqb force-pushed the feat/settlement_challenge_query branch from 0d01885 to add6204 Compare May 19, 2023 10:27
@ulbqb ulbqb force-pushed the feat/settlement_challenge_query branch from add6204 to d764401 Compare May 19, 2023 10:31
@ulbqb ulbqb marked this pull request as ready for review May 19, 2023 12:35
@ulbqb ulbqb requested a review from Mdaiki0730 June 21, 2023 02:20
@ulbqb ulbqb closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant