Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: catch up with the upstream's module versions #1007

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented May 17, 2023

Description

This patch would catch up with the upstream's module versions, which are:

  • x/auth: 2
  • x/bank: 2
  • x/distribution: 2
  • x/slashing: 2
  • x/staking: 2

Motivation and context

Before the planned huge bump up, we should catch up with the consensus versions, so we can use the upstream's migrator as is.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added Do not merge A: State Machine Breaking Any changes that result in a different AppState given same genesisState and txList. labels May 17, 2023
@0Tech 0Tech self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (999c7e7) 69.74% compared to head (1519727) 69.75%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   69.74%   69.75%           
=======================================
  Files         643      643           
  Lines       67255    67255           
=======================================
+ Hits        46906    46912    +6     
+ Misses      18176    18170    -6     
  Partials     2173     2173           

see 3 files with indirect coverage changes

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant