Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom r/w gRPC options (backport #1017) #1018

Merged
merged 2 commits into from
May 30, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 27, 2023

Description

backport #1017 to v0.47.0

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog

(cherry picked from commit 13ae1f6)
@zemyblue zemyblue added the A: bug Something isn't working label May 27, 2023
@zemyblue zemyblue self-assigned this May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (rc/v0.47.0.1-rc@4f96389). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             rc/v0.47.0.1-rc    #1018   +/-   ##
==================================================
  Coverage                   ?   62.04%           
==================================================
  Files                      ?      655           
  Lines                      ?    78960           
  Branches                   ?        0           
==================================================
  Hits                       ?    48987           
  Misses                     ?    27289           
  Partials                   ?     2684           

Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 154d1aa into Finschia:rc/v0.47.0.1-rc May 30, 2023
@zemyblue zemyblue deleted the feat/pr1017 branch May 30, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants