Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golang version #1025

Merged
merged 3 commits into from
Jun 8, 2023
Merged

chore: update golang version #1025

merged 3 commits into from
Jun 8, 2023

Conversation

shiki-tak
Copy link
Contributor

Description

This branch uses golang version 1.19 ahead of time.

The fixed test case is similar to cosmos-sdk update from 1.18 to 1.19.

cosmos/cosmos-sdk@v0.45.10...v0.45.16#diff-a0c3450e59ee801d721425680c1a50e836d3e4d7baae7fec2c4ec03ebfdf2d76R82

cosmos/cosmos-sdk@v0.45.10...v0.45.16#diff-1b93526887e605cf730c42e7a98bd245da82183ba2f77536a39d211c4c58ff30R131

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (for-ramus@e424237). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4872443 differs from pull request most recent head aa91ae8. Consider uploading reports for the commit aa91ae8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             for-ramus    #1025   +/-   ##
============================================
  Coverage             ?   61.95%           
============================================
  Files                ?      674           
  Lines                ?    79207           
  Branches             ?        0           
============================================
  Hits                 ?    49069           
  Misses               ?    27444           
  Partials             ?     2694           

Copy link
Member

@Mdaiki0730 Mdaiki0730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiki-tak shiki-tak merged commit 17ab59d into Finschia:for-ramus Jun 8, 2023
@0Tech 0Tech mentioned this pull request Jul 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants